search

bassmanitram / actions-for-nautilus

An extension to the Gnome "Files" file manager that allows you to add arbitrary actions to the file selection context menu.
Apache License 2.0
165 stars 16 forks source link

Import jquery from configurator's javascript folder instead of user's share directory #33

Closed BJaroszkowski closed 1 year ago

BJaroszkowski commented 1 year ago

Small fix which could be related to #9 - at least symptoms were identical in my case. Since jquery script is included in the source files anyway it seems there is no reason to rely on its existence in user's system (which may not be the case).

bassmanitram commented 1 year ago

Firstly thanks for taking the time to do this!

However, it's not as simple as that. The Debian lint process for the deb package spots that and issues a breaking warning that I shouldn't be doing that but, instead, using jquery installed by Debian.

The Deb file has jquery as a dependency. I'm assuming you installed A4N by clone/make otherwise this shouldn't have been a problem. Perhaps I simply update the doc to add that as a dependency (which I probably should have done anyway)?

(The delivery of jquery in the project is a non-cleaned-up relic of pre-deb days).

BJaroszkowski commented 1 year ago

OK, that explains a lot because I was actually trying to get it to work on Arch via manual installation. Installing AUR package jquery also did the trick. It is certainly worth mentioning in the manual installation section of README (and perhaps jquery should be deleted from the source files?). Anyway, feel free to close this PR.

Also, I am looking forward to support for Nautilus 4. Keep up the good work :)

bassmanitram commented 1 year ago

OK, thanks.

README updated to include jquery in the dependencies cited for manual installation: https://github.com/bassmanitram/actions-for-nautilus/commit/d6f3b82ac0884e686fb4ca6d6ac3e9ad93840b16