search

bassmanitram / actions-for-nautilus

An extension to the Gnome "Files" file manager that allows you to add arbitrary actions to the file selection context menu.
Apache License 2.0
165 stars 16 forks source link

The Configuration UI is open to all #41

Closed rahulhaque closed 1 year ago

rahulhaque commented 1 year ago

The json configuration web portal can be accessed by anyone connected to the same network if he/she knows the port number it is running on. Is it possible to close the server from the UI or any other way?

bassmanitram commented 1 year ago

When you close the tab, the server SHOULD close. If you are not seeing that then I need to address it.

I had intended to only open on the localhost interface! That appears NOT to be the case, for which I sincerely apologise. I'll produce an emergency patch to fix that! ROOKIE mistake!

I can also try to secure the Comms and access by other means, which will take a bit longer to research!

Thanks for the report.

Martin Bartlett

On Sat, 25 Feb 2023, 08:05 rahulhaque, @.***> wrote:

The json configuration web portal can be accessed by anyone connected to the same network if he/she knows the port number it is running on. Is it possible to close the server from the UI or any other way?

— Reply to this email directly, view it on GitHub https://github.com/bassmanitram/actions-for-nautilus/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAKLWWJ2E35BOKVVHM6FSTWZGVKRANCNFSM6AAAAAAVHWDWHM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rahulhaque commented 1 year ago

When you close the tab, the server SHOULD close. If you are not seeing that then I need to address it.

Yes, after closing the tab, the server still running in the background. I am on PopOS 22.04.

I had intended to only open on the localhost interface! That appears NOT to be the case, for which I sincerely apologise. I'll produce an emergency patch to fix that! ROOKIE mistake!

No worries, take your time.

Waiting eagerly for the next update. IMHO you can try to make the configuration editor offline to serve as a html file. Then open that html file in the browser instead of running a new server. BTW thank you for this.

bassmanitram commented 1 year ago

@rahulhaque - the referenced PR fixes it. Any chance you can test too? (I'll prep the release)

bassmanitram commented 1 year ago

When you close the tab, the server SHOULD close. If you are not seeing that then I need to address it.

Yes, after closing the tab, the server still running in the background. I am on PopOS 22.04.

I had intended to only open on the localhost interface! That appears NOT to be the case, for which I sincerely apologise. I'll produce an emergency patch to fix that! ROOKIE mistake!

No worries, take your time.

Waiting eagerly for the next update. IMHO you can try to make the configuration editor offline to serve as a html file. Then open that html file in the browser instead of running a new server. BTW thank you for this.

Can you tell me what browser you are using - I too am on PopOS 22.04, I'm using Chrome

bassmanitram commented 1 year ago

Arghgh - indeed, under Firefox it is NOT closing! Looking into it

bassmanitram commented 1 year ago

Latest commit in the PR fixes that for FF (and still works for Chrome).

bassmanitram commented 1 year ago

Actually, because of the seriousness, I'm going to merge the PR to master and prep the release.

rahulhaque commented 1 year ago

I am running Brave Browser. Which I guess equivalent to Chrome.

rahulhaque commented 1 year ago

@bassmanitram I've tested in brave browser and it is working fine. The port is also listening to only 127.0.0.1. Time to release a new version and update the .deb packages. Thank you.

bassmanitram commented 1 year ago

Excellent thx - release is prepped and should be there in a few moments.

Thanks for the report and sorry for the very embarrassing error!

rahulhaque commented 1 year ago

No worries, happens to all of us. Take care. 🙂