basst314 / ngx-webcam

A simple Angular webcam component / pure & minimal, no flash-fallback
https://basst314.github.io/ngx-webcam/?
MIT License
228 stars 104 forks source link

Replacement to MediaStreamError #130

Closed vasharma05 closed 2 years ago

vasharma05 commented 3 years ago

What is this issue about?

This issue Is about the removal of MediaStreamError in typescript 4.4, as mentioned in https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1029. Since the file path https://github.com/basst314/ngx-webcam/blob/master/src/app/modules/webcam/domain/webcam-init-error.ts#L3.

Do look into the issue asap. Waiting for a reply.

Thanks!

hisham commented 2 years ago

+1. This comes up as an issue with Angular 13 now.

Mds92 commented 2 years ago

The same problem

ChrisLoes commented 2 years ago

same problem. Does anybody has a solution? :/

vdnprasad commented 2 years ago

Still getting same problem even I've used typescript 4.4 onward and angular cli version is 13.

chriskinzel commented 2 years ago

@ChrisLoes as a quick fix I added this to my typings.d.ts global types file.

declare global {
  type MediaStreamError = Error;
}
ChrisLoes commented 2 years ago

already fixed with #134, should only be merged.

alexrait commented 2 years ago
declare global {
  type MediaStreamError = Error;
}

For this to work, we need to add export {} at the top. But it solved it for now, thank you.

KandarpRami174 commented 2 years ago

"MediaStreamError" change to "EndOfStreamError"

this is work for me

beyondtheobservableuniverse commented 2 years ago

@ChrisLoes as a quick fix I added this to my typings.d.ts global types file.

declare global {
  type MediaStreamError = Error;
}

How can i add this to Angular?

chriskinzel commented 2 years ago

@beyondtheobservableuniverse create a file typings.d.ts under your Angular project src directory and paste into there. Make sure your tsconfig is set to automatically include .d.ts files.

basst314 commented 2 years ago

This has been fixed in #134 and is part of version 0.4.1 of this library. Please update to the latest version.

jbistis commented 2 years ago

Does this 0.4.1 require a13? If yes, is there a fix that does not require an upgrade to a13? We are running 12.2.6 with 4.2.4.

jbistis commented 2 years ago

basst314, I upgraded to a13.1.2 with typescript 4.5.4 and ngx-webcam 0.4.1. I am still getting the error Cannot find name 'MediaStreamError'. Did you mean 'EndOfStreamError'? What can I do to fix this?

KillianLu commented 1 year ago

I think that was not fixed