mismatched arch session-manager-plugin got bundled

[chenrui333]

While packaging for homebrew, I noticed that the wrong arch session-manager-plugin got bundled (below is npm build for a apple arm machine):

Warning: Binaries built for a non-native architecture were installed into basti's prefix.
The offending files are:
  /opt/homebrew/Cellar/basti/1.6.2/libexec/lib/node_modules/basti/node_modules/basti-session-manager-binary-darwin-arm64/session-manager-plugin (x86_64)

[BohdanPetryshyn]

Looks like the session-manager-plugin version used (1.2.295.0) doesn't output binaries for the darwin_arm architecture during the build so Basti uses darwin_amd64 instead. Here's the list of build outputs:

I'll take a look if a new version of the plugin supports darwin_arm this week. Meanwhile, I have a couple of questions:

1. Is this issue blocking the Brew formula release?
2. Maybe another binary from the screenshot above can be used for darwin_arm?

[BohdanPetryshyn]

I replied in the Homebrew PR. Looks like the plugin doesn't support arm architecture natively and amd64 works well with arm Macs.

[chenrui333]

if you can point me the source, I can probably try to do some native source build with it.

[BohdanPetryshyn]

That would be great! Here's the repo: https://github.com/aws/session-manager-plugin

Please, also be aware of this issue: https://github.com/aws/session-manager-plugin/issues/57. If possible, I'd recommend using the exact version used right now (1.2.295.0) since it looks like the later versions still have the problem discussed in the issue.

[chenrui333]

since it looks like the later versions still have the problem discussed in the issue.

is it the same issue with the newer version?

[BohdanPetryshyn]

Unfortunately, I won't be able to test this right now but the same issue was reported again a month ago (https://github.com/aws/session-manager-plugin/issues/93) and people are reporting the same issues in comments (https://github.com/aws/session-manager-plugin/issues/57#issuecomment-2025129630, https://github.com/aws/session-manager-plugin/issues/93#issuecomment-2009941346).

[BohdanPetryshyn]

I'm closing this issue due to inactivity. Brew formula was successfully implemented without fixing this.