Add various enhancements

bastianraschke / pyfingerprint

Python library for ZhianTec fingerprint sensors (e.g. ZFM-20, ZFM-60)

Other

190 stars 115 forks source link

Add various enhancements #109

Closed Jakar510 closed 3 years ago

Jakar510 commented 3 years ago

Context Handler Support
In addition to Context Handlers, can pass in a serial object or create one internally.
Added convenience methods
Move SystemParameters to a more usable and readable object

bastianraschke commented 3 years ago

Hello @Jakar510, thanks for the pull request and sorry for the delayed response. At the moment we are very busy in career terms so we have less time to check it out. There are a lot of changes and we want to review carefully. Bastian

Jakar510 commented 3 years ago

As it's still not merged, can I create a new package and upload it to PyPi?

bastianraschke commented 3 years ago

To be honest, I don't see a big advantange to the users. I don't like the restructurements of the files, there are also a lot of commented code and finally I don't like the headers with "Property of TrueLogic Company" etc. If you are want to use your changes you are free to work with your fork but its nothing for the main repository/official PIP package.