search

bastibe / SoundCard

A Pure-Python Real-Time Audio Library
https://soundcard.readthedocs.io
BSD 3-Clause "New" or "Revised" License
680 stars 69 forks source link

Add local pyinstaller hook #86

Closed Bob-Thomas closed 4 years ago

Bob-Thomas commented 4 years ago

This should remedy #77 by having a local pyinstaller hook according to the new pyinstaller community hooks.

as proposed in https://github.com/pyinstaller/pyinstaller/pull/4834

@Legorooj could you perhaps validate this method as I just grabbed the wgpu example and rolled with it

bastibe commented 4 years ago

Cool, thank you! Thank you very much for putting effort into this!

We'll wait a few days for @Legorooj to answer before we merge.

bastibe commented 4 years ago

Thank you very much, gentlemen!

(I wish I knew how to set up CI for SoundCard; but it heavily relies on the audio hardware, and can't really be tested without that. Any tips would be very welcome!)

Legorooj commented 4 years ago

@bastibe afraid not... Some sort of emulation would be best, but otherwise I'm not sure.

Please note that this addition won't have any affect on PyInstaller until next release. (4.0: May-June)

bastibe commented 4 years ago

Please note that this addition won't have any affect in PyInstaller until next release. (4.0: May-June)

I think that's acceptable.