bastibe / annotate.el

Annotate.el
Other
388 stars 20 forks source link

Annotations in read-only buffers #101

Closed indigoviolet closed 3 years ago

indigoviolet commented 3 years ago

I originally wrote this as a comment here: https://github.com/bastibe/annotate.el/issues/74#issuecomment-820828751, but I noticed a couple of related bugs so wanted to call it out into its own issue.

1) Clearing annotations from a read only buffer does not work for me

2) annotate-summary-of-file-from-current-pos gets out of sync if I delete an annotation for a read-only buffer (ie. it doesn't get deleted from the buffer itself).

Thank you for this library!

cage2 commented 3 years ago

Hi!

You spotted two new bugs, thanks!

The first is interesting too!

To be honest annotate-summary-of-file-from-current-pos was kind of an hack and needs to be inspected and tested a bit more because i suspect there are more problems hiding in that part of the code.

I think i can starts working on these bugs next weeks unfortunately because of some stuff i have to deal with.

Bye! C.

indigoviolet commented 3 years ago

Thanks for the response. No rush, this is not a deal breaker.

cage2 commented 3 years ago

Hi!

the first has been fixed in #102

Bye! C.

cage2 commented 3 years ago

Hi!

Also item number 2 should be fixed in #102

Bye!! C.

cage2 commented 3 years ago

Fixed in #102