Prevented saving a file with an empty database;

bastibe / annotate.el

Annotate.el

Other

388 stars 20 forks source link

Prevented saving a file with an empty database; #107

Closed cage2 closed 3 years ago

cage2 commented 3 years ago

Hi!

This patch try to address #104.

The general idea is (in function annotate-dump-annotation-data) to prevent the annotation file to be saved, or delete it, if the annotation database is empty (i.e. there are not buffers with annotated text when annotate-dump-annotation-data is called).

Bye! C.

bastibe commented 3 years ago

Looks reasonable.

cage2 commented 3 years ago

Hi!

Looks reasonable.

Good! Honestly i did not like the idea to delete entirely the file but the motivations suggested in the report was valid to me so changing the managing of empty database was the right thing to do, in my opinion; i am happy to know that you also think the changes this PR introduce are good! Now I would wait some times (a week?) waiting for feedback from the user that opened the issue report before merging this, do you think is it OK?

Bye! C.

indigoviolet commented 3 years ago

@cage2 Thank you for your work on this change. I pulled and tested it and it seems to work perfectly!

cage2 commented 3 years ago

Hi!

@cage2 Thank you for your work on this change. I pulled and tested it and it seems to work perfectly!

That's wonderful! I need to change the accessory files and version and i am going to merge this PR.

Bye and thanks for your help and suggestions! C.

cage2 commented 3 years ago

Hi @bastibe !

I have updated version to 1.3.0 as there is a non trivial changes in the program behaivour here. Also i have added just me to the NEWS file, but if you want to be added tour name too, you know i am totally OK with that!

Bye! C.

bastibe commented 3 years ago

Great work, as always!

cage2 commented 3 years ago

Hi @bastibe !

Thank you!! :)

Merging in a sec! :)

Bye! C.