search

bastibe / annotate.el

Annotate.el
Other
384 stars 20 forks source link

- removed the use of 'after-save-hook', used 'kill-buffer-hook' and 'kill-emacs-hook', instead. #132

Closed cage2 closed 2 years ago

cage2 commented 2 years ago

Using these two hooks prevents the buffer to be marked as modified when, in fact, only the annotation has been changed (or added/deleted).

Bye! C.

cage2 commented 2 years ago

On Thu, Jun 30, 2022 at 11:39:44PM -0700, you wrote:

@bastibe commented on this pull request.

Hi!

@@ -58,7 +58,7 @@ ;;;###autoload (defgroup annotate nil "Annotate files without changing them."

  • :version "1.6.0"
  • :version "1.6.1"

This is technically a regression, i.e. a major version change. But that feels silly. It should probably be a minor version change, though, as it is more than a bugfix, right?

Thanks for discussing this, i was not sure the new version number attribution, in fact. In a sense this patch fixes a tiny bug, but doing that changes dramatically the behaviour of the program. What is your opinion if we would move to 1.7.0?

Bye! C.

bastibe commented 2 years ago

I think 1.7.0 is the right thing to do.

cage2 commented 2 years ago

Hi @bastibe !

I think 1.7.0 is the right thing to do.

Very well! I am going to change the relevant files and will merge! :)

Thanks! C.