bastibe / annotate.el

Annotate.el
Other
384 stars 20 forks source link

Restored annotation of info files. #143

Closed cage2 closed 1 year ago

cage2 commented 1 year ago

Hi @bastibe !

I am going to ask to the user that submitted the PR if this patch improve the performances with remote files too as this PR supposed to fix also #141.

Bye! C.

bastibe commented 1 year ago

Looks good, although I don't quite understand all the intricacies. Narrowing and remote files and such sound like a headache for annotations, though.

cage2 commented 1 year ago

On Wed, Nov 23, 2022 at 11:54:04PM -0800, you wrote:

Hi!

Looks good, although I don't quite understand all the intricacies. Narrowing and remote files and such sound like a headache for annotations, though.

I can guarantee they are a source of headache for who write the code, too. ;-D I was surprised (a good surprise!) that remote files and annotate works at all! :) I think the ability to annotate remote files is cool!

I hope that this patch will fix all the issues related to this features but I would not bet on it! :-D

Bye! C.

cage2 commented 1 year ago

Hi @bastibe !

I would merge this path, if you agree.

Bye! C.

cage2 commented 1 year ago

Hi!

Merging in a second!

Also happy vacation @bastibe ! :D :D

C.

bastibe commented 1 year ago

And happy holidays to you, too!

cage2 commented 1 year ago

And happy holidays to you, too!

Thanks!! 🙏 😃 C.