search

bastibe / annotate.el

Annotate.el
Other
384 stars 20 forks source link

- fixed managing return value of "(get-text-property changed-face-pos 'face)" #64

Closed cage2 closed 4 years ago

cage2 commented 4 years ago

Hello!

When finding the face of a portion of buffer, to try to get the right positioning of the annotation, using:

(get-text-property changed-face-pos 'face)

the code assumed this function returned a symbol (the face of the text) or nil: this is incorrect according to the documentation; the code above can returns a symbol, a plist or even list of symbols!

This patch try to deal with the different types of object the above code can returns.

see: #63

Bye! C.

bastibe commented 4 years ago

Awesome!

Oh, the wondrous intricacies of Emacs. When I read a documentation like that, I try to imagine the stories behind it; what prompted them to implement that. There is history in a simple function description as that.

Anyway, looks good!

cage2 commented 4 years ago

On Wed, Mar 25, 2020 at 02:19:55AM -0700, Bastian Bechtold wrote:

Hello Bastian!

Awesome!

Thanks to willthefrog, for signalling this issue!

Oh, the wondrous intricacies of Emacs. When I read a documentation like that, I try to imagine the stories behind it; what prompted them to implement that. There is history in a simple function description as that.

Sometimes digging into emacs is like checking geological sample, with layers and layers of history in it! :)

Anyway, looks good!

Very well! I just upgraded the version number.

With your and willthefrog permission i would like to mention the issuer in NEWS file (something simple as thanks to willthefrog for reporting this bug).

Do both of you agree? Willthefrog how do you want to be mentioned? Is Willthefrog OK?

Bye! C.

bastibe commented 4 years ago

I'm certainly OK with it.

You could even cherry-pick his original commit and rebase your changes off that. While that wouldn't change anything in the code, it would acknowledge his contribution in the Git tree.

cage2 commented 4 years ago

On Thu, Mar 26, 2020 at 12:15:50AM -0700, Bastian Bechtold wrote:

Hello Bastian!

I'm certainly OK with it.

You could even cherry-pick his original commit and rebase your changes off that. While that wouldn't change anything in the code, it would acknowledge his contribution in the Git tree.

As i didn't get any feedback from the issuer i added to the news file just the reference to the issue as acknowledgement for highlighting a bug.

If OK i would merge this PR.

Bye! C.

bastibe commented 4 years ago

Great! Merge away!

cage2 commented 4 years ago

Great! Merge away!

Right! :+1: Merged! :)

bye! C.