search

bastibe / annotate.el

Annotate.el
Other
384 stars 20 forks source link

Automatically expand overlapping annotation #83

Closed xeruf closed 3 years ago

xeruf commented 3 years ago

I accidentally placed my annotation on only a few words, but I intended to annotate the whole line:

image

When selecting the whole line and pressing C-c C-a, I get the following error:

image

I would have expected it to widen the annotation to my selection and then simply let me edit the text. It seems with the current behavior I have to copy the annotation text, delete the annotation and then create it again...

bastibe commented 3 years ago

Great idea, actually, to widen the annotation instead of throwing an error.

cage2 commented 3 years ago

On Mon, Oct 26, 2020 at 01:54:29AM -0700, Bastian Bechtold wrote:

Hi Bastian!

Great idea, actually, to widen the annotation instead of throwing an error.

I agree that this is a good idea and that i would like to try to implement! :)

Bye! C.

cage2 commented 3 years ago

Hi @xerus2000 !

I have just filed a PR (#87) that should address your issue, i wonder if i has been able to deal with all the cases when an annotation can overwrite others. Would be great if you could check this branch and makes some minimal testing. Could you?

Bye and thanks in advance! C.

xeruf commented 3 years ago

I'll see, currently busy with other stuff, and annotate is kinda not serving me that well since I often edit files after annotating them ;)

cage2 commented 3 years ago

On Wed, Dec 02, 2020 at 12:09:23PM -0800, Janek wrote:

Hi!

I'll see, currently busy with other stuff, and annotate is kinda not serving me that well since I often edit files after annotating them ;)

No problem! take your time and thank you anyway! :)

Bye! C.