bastibe / annotate.el

Annotate.el
Other
384 stars 20 forks source link

Remove compilation warnings #99

Closed cage2 closed 3 years ago

cage2 commented 3 years ago

Hi!

After trying to address #97 and the excellent suggestion from Emacs Doom maintainer from https://github.com/hlissner/doom-emacs/issues/4783 i realized i introduced many subtle inconsistencies in the code (and even an actual bug as in #97!).

Fortunately the compiler is smart enough ;-) to recognize some of them and i tried to make it happy removing al the warning (and hopefully resolve #97 as well). :)

Bye! C.

bastibe commented 3 years ago

Brilliant! It's so great to see Emacs folks all over the planet helping one another.

cage2 commented 3 years ago

On Sun, Mar 14, 2021 at 05:49:25AM -0700, Bastian Bechtold wrote:

Hi!

Brilliant! It's so great to see Emacs folks all over the planet helping one another.

And thanks to you for carefully check the code i write (something i really need)!

Bye! C.

cage2 commented 3 years ago

On Sun, Mar 14, 2021 at 05:48:12AM -0700, Bastian Bechtold wrote:

  • (font-lock-ensure nil))
  • (font-lock-flush nil))

The nil argument here is probably unnecessary now.

True! Just pushed the fix.

Bye! C.

bastibe commented 3 years ago

Quite a big new release! Thank you for all your hard work!

cage2 commented 3 years ago

On Sun, Mar 21, 2021 at 01:12:52PM -0700, Bastian Bechtold wrote:

Hi!

Quite a big new release! Thank you for all your hard work!

Thank you! I feel a bit sad that i did not tried to compile the package before this way i left some bug unnoticed (by me), i think i have learnt the lesson and i am going to compile the package to check for warnings.

Bye! C.

cage2 commented 3 years ago

Merging, thanks to all the people that helped with this patch!