search

bastibe / lunatic-python

A two-way bridge between Python and Lua
http://labix.org/lunatic-python
GNU Lesser General Public License v2.1
303 stars 83 forks source link

Made changes to CMakeLists.txt to work with Python3 and Python2 #88

Closed sudheerhebbale closed 4 months ago

sudheerhebbale commented 4 months ago

One minor thing after the set of changes in the previous pull request, pertaining to extracting and formatting Python exception in lua.

The cmake file looks for Python 2.7. Currently Python 3 is more in vogue.

There is a cmake module FindPython available which first looks for availability of Python3 and then for Python2 in that order and locates appropriate development environment and libraries.

This change makes the build go through without any changes to CMakeLists.txt file, which otherwise was becoming necessary for Python 3 environments.

Request review and merger of this.

greatwolf commented 4 months ago

why is the commit touching every line in the cmake file? Is it because of the end line return character?

sudheerhebbale commented 4 months ago

Some unwanted ^M(ctrl-M) characters were removed using the vim editor, which shows changes to all lines. Hence github shows difference on all lines.

If you view the changes by using "Hide white spaces check box" next to the "conversations" dropdown, only the relevant changes will be shown.

sudheerhebbale commented 4 months ago

Will this change be OK?

greatwolf commented 4 months ago

it should be okay, @bastibe should we merge this in?

sudheerhebbale commented 4 months ago

should we merge this in?

Yes, it will help

bastibe commented 4 months ago

Looks good to me!