Closed ghost closed 8 months ago
Thank you for your pull request. I see that in addition to the (setf (alist-get
, you also changed the defun
to cl-labels
, and fit the code into use-package
.
I would prefer it if you reverted these two changes, or presented them in a separate pull request for discussion. The reason being that cl-labels
might not be as familiar to elisp novices as defun
, and not everyone uses use-package
. The README should focus on being easy to understand first and foremost, I think.
This should fix #343