Remove key definition in the package loading.

bastibe / org-journal

A simple org-mode based journaling mode

BSD 3-Clause "New" or "Revised" License

1.24k stars 123 forks source link

Remove key definition in the package loading. #345

Closed sstepashka closed 1 year ago

sstepashka commented 3 years ago

Avoid modification of Emacs behavior on the package loading.

In order to follow the coding convention, disable key definition in the package loading

casch-at commented 3 years ago

Hey @sstepashka! Good point. We should however also update the README.org file which mentions it in several places that org-journal-new-entry can be called with the key C-c C-j.

sstepashka commented 3 years ago

Hey @cslux! I updated the document and added "C-c C-j" in org-journal-mode. It was mentioned in the documentation, but seems like it wasn't defined in there.

bastibe commented 3 years ago

As this is a breaking change, it should probably get a (temporary) mention near the top of the README.

Otherwise, looks good to me!