search

bastibe / org-journal

A simple org-mode based journaling mode
BSD 3-Clause "New" or "Revised" License
1.23k stars 122 forks source link

Add feature to turn off scheduled entries having a timestamp. #390

Open tostr7191 opened 2 years ago

tostr7191 commented 2 years ago

As per #389, I am adding a PR that adds this feature. First time working with this, and I am also on the move, so not quite sure everything is correct. But it looks simple enough, hoping that it actually is.

Otherwise, please feel free to critique in any way, I should have a bit more time next week (but my schedule said I need to do this today, so I complied! ;))

tostr7191 commented 2 years ago

Ok, now I had a bit of time to figure out how to test. All three obvious cases work with expected behaviour (not set, set to t and set to nil).

bastibe commented 2 years ago

Thank you very much, and sorry for forgetting this pull request for so long!

Would you like to add a note to the README for the new customization variable? Or should this remain in the customization menu only? I'm fine with either approach.

I'll merge the PR when you say it's ready.