search

bastibe / org-journal

A simple org-mode based journaling mode
BSD 3-Clause "New" or "Revised" License
1.23k stars 122 forks source link

[BUG] tab org-cycle appears no longer bound/working in org-journal Journal mode #392

Open wakatara opened 2 years ago

wakatara commented 2 years ago

Describe the bug

On visiting my org-journal file, tab no longer seems to open or close headings a la org-cycle.

To Reproduce

2 things about my journal flie:

  1. It is yearly
  2. It is encrypted (so org.gpg extension)

Visit file normally via org-journal-new-entry (bound to CMD-j in my system), selecting the journal file in Deft, or byopening the file normally. For some reason, the org-cycle, tab binding which worked until very recently does not work. Tab to org-cycle headings works fine in normal (non-journal) org-mode files fine.

nb: C-c C-f and C-c C-b for opening forward and previous entries does work - sp there is a workaround.).

Expected behavior

Tab on a headline should org-cycle headings. At the moment it merely does nothing (a particular problem if the journal flie opens up completely folded by date)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Your Emacs Configuration The part relevant to org-journal.


;; Org Journal config
(use-package org-journal
  :straight t
  :defer t
  :custom
  (org-journal-dir "~/Library/Mobile Documents/iCloud~com~appsonthemove~beorg/Documents/org/journal")
  (org-journal-file-type 'yearly)
  ; (org-extend-today-until 01)
  (org-journal-file-format "journal-%Y.org")
  (org-journal-date-format "%Y-%m-%d %a")
  (org-journal-created-property-timestamp-format "%Y-%m-%d")
  (org-journal-encrypt-journal t)
  (org-journal-enable-cache t)
  (org-journal-carryover-items nil))
bastibe commented 2 years ago

Does it work if you open your journal file in org-mode instead of org-journal-mode?

wakatara commented 2 years ago

Strangely, if I open the file via Deft (even in Journal mode), it works fine. The issue seems to be with it opening via the org-journal-new-entry command (which I have keymapped to M-j).

Switching the file to org mode when it is not working makes it work (as does then flipping it back to org-journal-mode).

Why it's not working after the new entry command is issued has me a bit stumped. (I did a recent straight-pull-all so imagine it updated from a much earlier version of the package then.).

bastibe commented 2 years ago

As far as I know, we aren't doing anything with the tab key. No idea what's happening here, honestly.

wakatara commented 2 years ago

Oh, I believe you. Bit stumped myself, as all I can think of it's some weird change made in org-mode or perhaps the origami plugin I use for ledger and uses outline mode is somehow interfering with things. Will poke around a bit more. Like I said, the strangest thing is it only seems to affect the file when I trigger it via the new journal entry command, which is... strange... =]

bastibe commented 2 years ago

Do let me know what you find out! Poking at org-journal's internals is always interesting.

wrrn commented 2 years ago

I've found that if I'm in org-journal-mode and run outline-hide-sublevels then the issue presents itself. Not sure why that causes an issue to be honest, but wanted to provide some details that might be helpful.

My journal file configs:

  (org-journal-file-header "#+TITLE: %B %Y")
  (org-journal-file-format "%Y-%m.org")
  (org-journal-dir (concat (getenv "HOME") "/.roam"))
  (org-journal-date-format "%A, %F")
  (org-journal-time-format "")
  (org-journal-file-type 'monthly)
  (org-journal-carryover-items "/!")
ngn999 commented 2 years ago

Same problem here. I think the bound works. When press , it shows: "SUBTREE (NO CHILDREN)", but it has some CHILDREN.

leo0liver commented 1 year ago

I'm having the same issue. Changing the org-journal-time-prefix to an empty string with: (setq org-journal-time-prefix "") Stops it from happening for me. However, doing this leads to another bug where my TODOs from the previous day wont get carried over and I get an error that says: "wrong-type-argument number-or-marker-p nil" The same as this issue: https://github.com/bastibe/org-journal/issues/65

samschulter commented 1 year ago

Hi. I had the exact same issue. But it seems to be fixed after I set org-fold-core-style to overlays instead of the default text-properties, so (setq org-fold-core-style 'overlays). Just for context, and maybe to further look into the issue, the reason I made this change is actually because of an issue I had with the consult package and I followed a solution from https://github.com/minad/consult/issues/563. Maybe this helps.

yubrshen commented 1 year ago

I'm having the same problem. I have isolated the symptom:

  1. It only happens after executing org-journal-new-entry
  2. And (org-cycle) will not work for all the journal entries but the last one (newly created journal entry)
  3. Perform M-x org-journal-mode will remove the problem I have org-journal-time-prefix set to "** " org-fold-core-style to 'text-properties

Yes, setting org-fold-core-style to 'overlays and re-execute M-x org-journal-mode, and adding another journal entry, I still can org-cycle the other entries' visibility. The problem is solved with the fix.