bastibe / org-static-blog

A static site generator using org-mode
BSD 3-Clause "New" or "Revised" License
341 stars 74 forks source link

add support for Open Graph Protocol meta tags #127

Closed unmonoqueteclea closed 10 months ago

unmonoqueteclea commented 10 months ago

Now, generated pages will contain some <meta> tags following the Open Graph Protocol. Many websites (such as Twitter, Facebook, Slack, Telegram, etc) use that protocol to generate url previews.

We are adding:

I am using this feature in my blog

This is just a first version, and I am happy to discuss possible improvements.

bastibe commented 10 months ago

As far as I can tell, this is missing the mandatory og:url entry.

bastibe commented 10 months ago

Thank you for the pull request! I like it.

However, I am worried that some users may find it off-putting to include what accounts to facebook metadata into their personal blogs. I would therefore prefer an option to disable the og:... meta-tag generation, and make it opt-in.

unmonoqueteclea commented 10 months ago

As far as I can tell, this is missing the mandatory og:url entry.

Done!

unmonoqueteclea commented 10 months ago

Thank you for the pull request! I like it.

However, I am worried that some users may find it off-putting to include what accounts to facebook metadata into their personal blogs. I would therefore prefer an option to disable the og:... meta-tag generation, and make it opt-in.

Done!

bastibe commented 10 months ago

Looks good to me!

Is this ready to merge from your end?

unmonoqueteclea commented 10 months ago

Absolutely!

bastibe commented 10 months ago

Thank you very much for your contribution! I love it!