search

bastibe / python-soundfile

SoundFile is an audio library based on libsndfile, CFFI, and NumPy
BSD 3-Clause "New" or "Revised" License
676 stars 105 forks source link

Require numpy for all installs #409

Closed mcclure closed 6 months ago

mcclure commented 9 months ago

See discussion in #408. This may not be how you prefer to solve this.

It would be better if numpy were requested with a >= version number but I don't know which one is appropriate.

bastibe commented 9 months ago

If we do this, we should additionally move the import numpy to the top of soundfile.py.

mcclure commented 9 months ago

That's reasonable, I added a comment (hoping the long line length is not a problem)

To be clear, I think it would be reasonable to keep in the buffer-only case if that's a use case you want to support. But my support conversations with this project so far implies the non-numpy case is not a development priority, so…

bastibe commented 9 months ago

The comment is good, thank you!

In theory, I'd prefer to keep the buffer-only use case alive in some form. But I think that it has almost no users, and the lack of numpy is causing much more trouble than it's worth. If you have a better solution, I'd be very interested.

But otherwise, I say this is a good change.