search

bastibe / transplant

Transplant is an easy way of calling Matlab from Python
https://transplant.readthedocs.io
Other
110 stars 26 forks source link

Fixed zmq header for windows and library installation tips for windows #14

Closed YoelShoshan closed 8 years ago

YoelShoshan commented 8 years ago

Fixed zmq header for windows and library installation tips for windows.

Notice that macros still need to be added to the header in order to choose different function declarations in linux/windows cases. This "transplantzmq.h" will work on windows but break linux.

bastibe commented 8 years ago

Thank you very much! I added a small change to transplantzmq.h, which should be correct on Windows and Unix alike. Can you check that the code still works on your end?

YoelShoshan commented 8 years ago

No problem - my pleasure :) I'll check and update soon.

YoelShoshan commented 8 years ago

ok, checked and it didn't work. The reason was that there's a conflict on the definition of size_t

I used procmon to see what cl.exe actually reads, and saw that in crtdefs.h, size_t was typedef to be unsigned __int64.

I will make a pull request for this today.