search

bastibl / gr-foo

Some GNU Radio blocks that I use.
GNU General Public License v3.0
106 stars 56 forks source link

fix CMake pybind11 configuration #31

Closed lucabaldesi closed 3 years ago

lucabaldesi commented 3 years ago

Hi, with reference to issue #30 I investigated the code of gr-satellites, which happens to have few extra lines compared to gr-foo/CMakeLists.txt to load pybind11 code in the buildchain. This PR fixes issue #30

Best, Luca

bastibl commented 3 years ago

Thanks for looking into the issue! Based on your findings, I had another look, in particular, at the current gr_modtool template, which doesn't include this section.

However, it turns out that 3.9.2 has a bug in GNU Radio's installed cmake module (the one that I referenced in #30). This bug was fixed in 3.9.3 (see https://github.com/gnuradio/gnuradio/commit/938940f95c7eb061875dc7f570458784f3f8b570#diff-692ca32a753599e2d5611681aa888ce47ab4cfc00d1fc54ec8ec4dfc638a7b46).

I'm not sure how to proceed. Either add your suggestion as a temporary workaround or recommend to update to GNU Radio 3.9.3. I tend towards the latter :-) What do you think?

lucabaldesi commented 3 years ago

Nice to hear they fixed the bug! No need to merge the PR, then. I will close the issue with the patch for interested people.

bastibl commented 3 years ago

thanks!