search

bastibl / gr-rds

FM RDS/TMC Transceiver
http://en.wikipedia.org/wiki/Radio_Data_System
GNU General Public License v3.0
218 stars 71 forks source link

Use unsigned char for radiotext & PS bytes #49

Closed argilo closed 2 years ago

argilo commented 2 years ago

This fixes a problem where 8-bit characters are sign-extended before being packed into infowords.

https://github.com/bastibl/gr-rds/blob/d43ead61d1ff7fbea327868505fd27925c10f6f8/lib/encoder_impl.cc#L382

https://github.com/bastibl/gr-rds/blob/d43ead61d1ff7fbea327868505fd27925c10f6f8/lib/encoder_impl.cc#L389-L396

This can't be tested directly in GRC since it doesn't seem to allow bytes parameters. But I was able to test it by manually editing the generated Python code. After the change, accented characters can be transmitted.

Note: RDS uses a special character set; see page 42 here for details: https://www.etsi.org/deliver/etsi_ts/101700_101799/101756/01.06.01_60/ts_101756v010601p.pdf

Signed-off-by: Clayton Smith argilo@gmail.com

bastibl commented 2 years ago

Thank you!