search

bastibl / gr-rds

FM RDS/TMC Transceiver
http://en.wikipedia.org/wiki/Radio_Data_System
GNU General Public License v3.0
220 stars 73 forks source link

Fix a couple more bugs in rds_rx.grc #52

Closed argilo closed 3 years ago

argilo commented 3 years ago

While transplanting rds_rx.grc into Gqrx (in https://github.com/gqrx-sdr/gqrx/pull/984), I noticed a couple of mistakes I made along the way:

  1. The frequency xlating filter used for RDS is too narrow.
  2. The AGC block has some leftover values from testing.

I've fixed those here.

Signed-off-by: Clayton Smith argilo@gmail.com

bastibl commented 3 years ago

Thanks again!

bastibl commented 3 years ago

I don't know. Would you mind checking?

argilo commented 3 years ago

There is key bug in tx that reverses FM channels, is that fixed?

Yes.

argilo commented 3 years ago

I had a look back, and I don't think that was broken in gr-rds. I tested the transmitter while working on https://github.com/bastibl/gr-rds/pull/50 and verified that the left & right channels were in the correct place.

argilo commented 3 years ago

I tested with Gqrx, which I've previously compared to a hardware receiver.

bastibl commented 3 years ago

The commit you linked is about a bug in the wfm_rcv_pll hierarchical block of GNU Radio, which is not used in this module. Can you please explain how the error of this block should have propagated to gr-rds?

bastibl commented 3 years ago

What you wrote is:

There is key bug in tx that reverses FM channels, is that fixed?? Same bug was in gnuradio, see this comment.

TX was checked as already mentioned.

And "Same bug was in gnuradio" doesn't make a lot of sense to me, since there was only a bug with RX in GNU Radio. In a block that gr-rds doesn't use. So why should the same bug be here?

If you are still concerned that there are problems. Please open an issue and describe in more detail what you think is wrong and why you think it is wrong. Thanks.

bastibl commented 3 years ago

If you are still concerned that there are problems. Please open an issue and describe in more detail what you think is wrong and why you think it is wrong. Thanks.