bastienpaulfr / Treessence

Some trees for Timber lib
Apache License 2.0
99 stars 10 forks source link

Device's Timezone information is getting lost #3

Closed rvullriede closed 4 years ago

rvullriede commented 5 years ago

Hi,

thx for these usefuls trees. However, I've discovered that Treessence (specifically the helper method timestampToDate() in TimeUtils) set the JVM's default Timezone hardcoded to UTC.

This means after the first log statement has been logged through Treessence the original timezone that was set by the user is lost!

bastienpaulfr commented 5 years ago

Hi thanks for your issue. It will be fixed in next version.

RoryKelly commented 4 years ago

Still exists in the latest version. happy to do a pr to fix

bastienpaulfr commented 4 years ago

Oups, my bad.

I will be pleased to read your PR !

Tks

bastienpaulfr commented 4 years ago

Could you please test tz version and give me your feedback ?

Repo : https://dl.bintray.com/bastienpaulfr/maven-snapshot

repositories {
    maven { url 'https://dl.bintray.com/bastienpaulfr/maven-snapshot' }
    ...
}

dependencies {
    implementation 'fr.bipi.treessence:treessence:tz'
}

Tks

bastienpaulfr commented 4 years ago

I have just released 0.3.2 of lib !