search

bastienqueste / SeaExplorerTools

Development branch of tools for initial loading, cleaning and basic processing of SeaExplorer data. Load into pandas, run platform and sensor specific processing, and leave in a state ready to be ingested by GliderTools (maybe?)
3 stars 3 forks source link

Refactor of ADCP processing #3

Open callumrollo opened 1 year ago

callumrollo commented 1 year ago

Aim to refactor all the functionality in the notebook RefactoringADCP.ipynb into self contained functions.

This process requires the following steps:

After these steps are complete, the ADCP processing will be ready for packaging/publication.

I will add PRs addressing each of my assigned tasks in the coming days.

Any more steps to add @bastienqueste?

bastienqueste commented 1 year ago

Thanks Callum, some tweaking and breaking up of code to give users choice would be valuable (which I guess is user visible processing flow). Some may chose 4-beam work, some 3. Some may want to regrid, some not. Best will be when things are broken down into individual functions.

Do we want to rely on MIDAS to produce netcdf, or do we want to automate binary decoding in python?

callumrollo commented 1 year ago

I had a crack at a binary decoding a while ago but didn't make any headway. To reverse engineer it I think we'd need documentation of the format and/or the assistance of Nortek engineers

bastienqueste commented 1 year ago

I have format documentation but it's a PITA.

B

Although I may work and communicate at strange hours, I do not expect replies outside of your own working hours.

Dr Bastien Y. Queste Assistant professor / Biträdande lektor Department of Marine Sciences, University of Gothenburg (UGOT) Carl Skottsbergs Gata 22B, SE-413 19 Gothenburg, Sweden Tel: +46-73-504-28-39 Home page: http://www.byqueste.com ORCID: https://orcid.org/0000-0002-3786-2275

From: Callum Rollo @.> Sent: 28 March 2023 14:09 To: bastienqueste/SeaExplorerTools @.> Cc: Bastien Queste @.>; Mention @.> Subject: Re: [bastienqueste/SeaExplorerTools] Refactor of ADCP processing (Issue #3)

I had a crack at a binary decoding a while ago but didn't make any headway. To reverse engineer it I think we'd need documentation of the format and/or the assistance of Nortek engineers

— Reply to this email directly, view it on GitHubhttps://github.com/bastienqueste/SeaExplorerTools/issues/3#issuecomment-1486761662, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABHOCWOHUNQN6L7FK5DY6TW6LIHFANCNFSM6AAAAAAWKOW56U. You are receiving this because you were mentioned.Message ID: @.***>