search

bastienqueste / SeaExplorerTools

Development branch of tools for initial loading, cleaning and basic processing of SeaExplorer data. Load into pandas, run platform and sensor specific processing, and leave in a state ready to be ingested by GliderTools (maybe?)
3 stars 3 forks source link

refactor out all processing to functions #4

Closed callumrollo closed 1 year ago

callumrollo commented 1 year ago

This addreses the first point of Issue #3

We use the output dictionary out as the testable output. I have added a cell at the end of the notebook that checks that out is unaltered after the refactor.

@bastienqueste if you are happy with this refactor that moves functions to an external script, I will refine it by cleaning up the functions, deleting unused code, standardising names etc.

callumrollo commented 1 year ago

Added an integration test to start addressing #5. The test data file is large though: 15 MB. For now, this will provide a safety check against refactoring changing the output. Eventually this will be replaced with unit tests for each function

callumrollo commented 1 year ago

@bastienqueste is this good to go? Then I can move on to the next stage

bastienqueste commented 1 year ago

Looks good to me!