search

bastihilger / nova-tiptap

Laravel Nova Tiptap Field
MIT License
172 stars 61 forks source link

Add id to field #33

Closed u12206050 closed 3 years ago

u12206050 commented 3 years ago

Reason for not putting it on text area is because it gets replaced by ProseMirror

bastihilger commented 3 years ago

Before merging this - for what purpose is this id normally used? If it is for styling, for example, where you put it is exactly the right location. If it is for content, it probably should be please on the .ProseMirror div, and I know a way how.

bastihilger commented 3 years ago

Because it is actually not the textarea, that gets replaced - the textarea is just for the HTML view of the editor.

u12206050 commented 3 years ago

In my case it is for match the element in dom, so either way will work for me as I'll just navigate my way around it once I have it.

On Sun, 31 Jan 2021, 18:56 Sebastian Hilger, notifications@github.com wrote:

Because it is actually not the textarea, that gets replaced - the textarea is just for the HTML view of the editor.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manogi/nova-tiptap/pull/33#issuecomment-770422047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSVMWRTVLOGLZRXKQMCBPTS4WKVRANCNFSM4W3SA22Q .

bastihilger commented 3 years ago

Thank you for your PR, I added it in v1.3.1