Add title attributes to toolbar buttons

bastihilger / nova-tiptap

Laravel Nova Tiptap Field

MIT License

172 stars 61 forks source link

Add title attributes to toolbar buttons #34

Closed Pothecary closed 3 years ago

Pothecary commented 3 years ago

Not an issue but a proposal.

Is it possible to add title attributes to the buttons in the editor toolbar? So when you hover over each button a helpful hint shows. Much like the GitHub editor here:

Mock up using Chrome dev-tools:

Whilst many of us developers will recognise the editor icons, there are some clients (the ultimate the end user) who may not.

bastihilger commented 3 years ago

This is a good idea. This would have to be translatable (I can provide German and English). And maybe the regular "title" attribute is not enough, maybe a tooltip like you said here in Github would be nice.

Would you like to PR this?

bastihilger commented 3 years ago

I just saw you seem to be new on GitHub - with "PR" I mean write a pull request, and if that is not possible for you, no problem, I will add this when I get around to it.

Pothecary commented 3 years ago

@manogi I'm certainly new to contributing but I am happy to give this a shot. I'm sure I can spare some time this week or next to look into this 😄

bastihilger commented 3 years ago

This is done now (in English and German):