search

bastihilger / nova-tiptap

Laravel Nova Tiptap Field
MIT License
172 stars 61 forks source link

Add support for hard break button #46

Closed ImJustToNy closed 2 years ago

ImJustToNy commented 2 years ago

https://tiptap.dev/api/nodes/hard-break

Not sure about the icon, but I couldn't find any better in fontawesome's free directory.

bastihilger commented 2 years ago

Hi there - thanks for the PR. Im not sure about it yet - could you explain the circumstances, where this is better than just using "shift + enter"?

ImJustToNy commented 2 years ago

IMHO the keystroke is not really intuitive for non-tech person. I think a button that does exactly that would be much more logical.

bastihilger commented 2 years ago

Thank you for your PR. It will be included in the next version which should be 2.5.0. I just used a "BR" as the label instead of the icon.