search

bastihilger / nova-tiptap

Laravel Nova Tiptap Field
MIT License
172 stars 61 forks source link

Allow customisation of image inline setting #54

Closed kenneth-hendricks closed 1 year ago

kenneth-hendricks commented 2 years ago

Hi,

It would be great if this library allowed users to set the inline setting for the images extension. This is required if you want to allow images to be made linkable. From what i can see there is no way to set this currently.

https://tiptap.dev/api/nodes/image

curder commented 2 years ago

Need this.

shaffe-fr commented 2 years ago

Hey @manogi, I'm preparing a PR for this issue, but I encounters troubles to install local dependencies because of FontAwesomePro. Can I PR the updated sources? You'll only have to compile them. Thanks

bastihilger commented 2 years ago

Yes, we can try this

shaffe-fr commented 2 years ago

IMO images should always be embed as inline. Do you agree or would you prefer a new imageSettings.inline option? Thanks

bastihilger commented 2 years ago

It will take me a bit longer to answer this - I am currently not actively using Nova (or TipTap) and will have to re-install my testing environment for it.

alexgilbertDG commented 1 year ago

Any updates on this ? I will open a PR if needed

shaffe-fr commented 1 year ago

Hey, I changed the rich text editor I'm using for creditor 4. I'll share what I already have.

shaffe-fr commented 1 year ago

Hey @alexgilbertDG, I have this https://github.com/shaffe-fr/nova-tiptap/tree/inline-image

alexgilbertDG commented 1 year ago

@manogi Any update about this issue, we would like to add <a href url for image and without that we can't do it....