search

bastihilger / nova-tiptap

Laravel Nova Tiptap Field
MIT License
172 stars 61 forks source link

Link modal is wrongly placed on tiptap v2.8.0 on Nova 3 #56

Closed cfc7-unikent closed 2 years ago

cfc7-unikent commented 2 years ago

Versions:

Description

When pressing the link button the link modal is placed down in the bottom right just off the screen.

2 8 0 - modal placement and toolbars

In the previous version 2.7.6 the modal is placed in the middle as expected.

2 7 6 - toolbars

Note in both versions then having more than TipTap field seems to result in the toolbars of each field on the screen appearing when the link modal is viewed.

bastihilger commented 2 years ago

HI there, thank you for notifying me. This is now fixed in v2.8.1

bastihilger commented 2 years ago

Ah well - the thing with the toolbars is not yet fixed.

cfc7-unikent commented 2 years ago

Many thanks for the fix - that does resolve the issue with the placement. :-)

What would be best about the thing with the toolbars? Would you like me to keep this issue open or would you like me to add it as a new separate issue?

bastihilger commented 2 years ago

Please keep it open - I'm fixing it with vue-portal

bastihilger commented 2 years ago

The toolbar situation is now fixed in v2.8.2

cfc7-unikent commented 2 years ago

That is absolutely brilliant! Many, many thanks @manogi :-)

All looks perfect to me 🎉