search

bastikr / boolean.py

Implements boolean algebra in one module.
BSD 2-Clause "Simplified" License
78 stars 34 forks source link

Fix minor typos in docs and use self.assertRaises in a test #63

Closed alisianoi closed 7 years ago

alisianoi commented 7 years ago

Sorry for not making this PR atomic, it is just three small changes together:

  1. Fixed all year ranges to end with 2017
  2. Fixed a couple small typos in docs
  3. Changed one test to use self.assertRaises

Now that test will fail if the exception is not raised. And it still checks the error_code of the exception (meaning, the test does not just end with a self.assertRaises). For details see:

http://stackoverflow.com/a/3166985/1269892

I am thinking about taking part in GSoC17 with AboutCode, possibly with the "porting the license expression library to JavaScript" because I have experience with both python and javascript. Please let me know if there are any other reasonable "steps forward" other than joining mail list/IRC (i.e. some projects rank applicants based on finished commts/PRs)

Update: nevermind, found https://gitter.im/aboutcode-org/discuss

pombredanne commented 7 years ago

@all3fox Thanks! Let me review this and merge. The giiter channel and the aboutcode mailing list are the place for discussions! As a side note, but this is not critical we like to have commits with a Signed-off-by: See https://github.com/nexB/aboutcode/wiki/Writing-good-commit-messages for some details.

pombredanne commented 7 years ago

Thanks. LGTM. Merging.