search

bastilimbach / docker-MagicMirror

Docker image for the Magic Mirror 2 project by Michael Teeuw.
https://hub.docker.com/r/bastilimbach/docker-magicmirror/
MIT License
185 stars 54 forks source link

Use GitHub actions instead of Travis #43

Open bastilimbach opened 4 years ago

bastilimbach commented 4 years ago

See https://github.com/bastilimbach/docker-MagicMirror/pull/25#issuecomment-652661315

Legion2 commented 4 years ago

@bastilimbach What is this line for? https://github.com/bastilimbach/docker-MagicMirror/blob/0d51263ff08cd27cede01bef161b8f02d741e293/build.sh#L6

bastilimbach commented 4 years ago

@Legion2 it checks if there is already an image with that particular tag/version on docker hub. This is to prevent overriding existing tags.

Legion2 commented 4 years ago

But there should be no problem if we override a tag with a newer build of the same tag. It uses the same code base but maybe newer base images and dependencies.