search

bastion-dev / Bastion

Java test library for HTTP APIs
http://bastion.rocks
GNU General Public License v3.0
13 stars 8 forks source link

Update the methods related to HTTP 'body' to refer to 'entity' instead #29

Closed KPull closed 7 years ago

KPull commented 8 years ago

We incorrectly refer to the content data inside HTTP message as the content 'body'. The HTTP specification calls this the "HTTP Entity". Even though this is a breaking API change, I believe that, given the library is still in BETA, we change all references to "body" and update them to "entity" instead to better reflect the standard.

KPull commented 7 years ago

Since the library is being used by people already, I think we leave it as is now since it's not a big deal anyway.

mariacamenzuli commented 7 years ago

I think the entity in the Http spec is not just the body. It is the body + certain headers.

"An entity consists of entity-header fields and an entity-body".

So I think we're using body correctly, since the headers are unrelated.

KPull commented 7 years ago

As explained in http://stackoverflow.com/questions/9197745/what-exactly-is-an-http-entity, Body is indeed the correct terminology. That's nice! :)

I'm closing the issue.