search

bastion-dev / Bastion

Java test library for HTTP APIs
http://bastion.rocks
GNU General Public License v3.0
13 stars 8 forks source link

Make Request/Assertions implementation classes final #46

Open KPull opened 7 years ago

KPull commented 7 years ago

Our Request and Assertions subclasses are not final in the sense that anyone can subclass them. This is NOT the intended use of these classes and should be marked final. If someone would like to extend their functionality, they should compose the classes rather than subclass them.

KPull commented 7 years ago

Should we do this? Alternatively we can indicate the intended use in each class' JavaDocs.