search

bastion-dev / Bastion

Java test library for HTTP APIs
http://bastion.rocks
GNU General Public License v3.0
13 stars 8 forks source link

Global timeout is ignored #54

Closed KPull closed 7 years ago

KPull commented 7 years ago

The global timeout value, set using Bastion.globals().timeout() is not used by Bastion at the moment. We need to fix this and apply the timeout, only if the user has not specified a different timeout in their request.

Maybe we could have a USE_GLOBAL_TIMEOUT constant which the RequestExecutor checks for. When this constant is returned by HttpRequest.timeout(), the timeout will be whatever is set in Bastion's globals.

KPull commented 7 years ago

@FrelliBB, want to take a look at this when you have a moment, please? Or maybe @benjie332? :)

KPull commented 7 years ago

Fixed in #68. :)