Closed mariacamenzuli closed 7 years ago
Yes, thanks for bringing this to our attention. So I think for this, we can put this down as a Known Issue and skip the test in case it is running on a Mac. We can use JUnit's Assume
class for this: http://junit.sourceforge.net/javadoc/org/junit/Assume.html. We should also make a note of this in FileRequest
's JavaDoc.
Want to do it yourself or shall I do it, @maria-camenzuli?
This might be resolved with https://github.com/bastion-dev/Bastion/pull/89
@maria-camenzuli could you check again if the test still fails on MacOS? I think this should be resolved now.
Built develop
on MacOS successfully.
Wonderful, thanks :)
The test
contentType_jsonFileType_contentTypeShouldBeJson
is failing when building Bastion on Mac. Bastion is failing to detect the file type and is therefore resorting to the defaulttext/plain
filetype instead of the expectedapplication/json
.I have discussed this with @KPull who found the following related links: