bastion-dev / Bastion

Java test library for HTTP APIs
http://bastion.rocks
GNU General Public License v3.0
13 stars 8 forks source link

FileRequest cannot guess given file's MIME type on MacOS #63

Closed mariacamenzuli closed 7 years ago

mariacamenzuli commented 7 years ago

The test contentType_jsonFileType_contentTypeShouldBeJson is failing when building Bastion on Mac. Bastion is failing to detect the file type and is therefore resorting to the default text/plain filetype instead of the expected application/json.

I have discussed this with @KPull who found the following related links:

KPull commented 7 years ago

Yes, thanks for bringing this to our attention. So I think for this, we can put this down as a Known Issue and skip the test in case it is running on a Mac. We can use JUnit's Assume class for this: http://junit.sourceforge.net/javadoc/org/junit/Assume.html. We should also make a note of this in FileRequest's JavaDoc.

Want to do it yourself or shall I do it, @maria-camenzuli?

FrelliBB commented 7 years ago

This might be resolved with https://github.com/bastion-dev/Bastion/pull/89

FrelliBB commented 7 years ago

@maria-camenzuli could you check again if the test still fails on MacOS? I think this should be resolved now.

mariacamenzuli commented 7 years ago

Built develop on MacOS successfully.

FrelliBB commented 7 years ago

Wonderful, thanks :)