Removed ambiguous StatusCodeAssertions#expecting method

bastion-dev / Bastion

Java test library for HTTP APIs

http://bastion.rocks

GNU General Public License v3.0

13 stars 8 forks source link

Removed ambiguous StatusCodeAssertions#expecting method #67

Closed dagre closed 7 years ago

dagre commented 7 years ago

This is a fix for #64 The StatusCodeAssertions#expecting method overloads were causing compile errors when passing in literal integers to the method. I retained the primitive int variant, since null status codes do not make sense. Also changed the assertion class itself to store a set of status codes, since duplicates are irrelevant in this case.

KPull commented 7 years ago

Welcome to Bastion, @dagre! Thanks for this pull request. Everything looks fine and I'm merging. Your contribution is much appreciated. :)

dagre commented 7 years ago

Awesome, thanks! :)