search

bastion-dev / Bastion

Java test library for HTTP APIs
http://bastion.rocks
GNU General Public License v3.0
13 stars 8 forks source link

Global timeout respected when Request does not provide its own #68

Closed dagre closed 7 years ago

dagre commented 7 years ago

This is a fix for #54

I implemented the fix as suggested by @KPull. I also changed the CommonRequestAttributes to default to the USE_GLOBAL_TIMEOUT constant, instead of 0, since most of the HttpRequest implementations override the timeout method and delegate it to this class. Looking for feedback if there's a better approach to doing this, and if there's a better place for the USE_GLOBAL_TIMEOUT constant.

dagre commented 7 years ago

Fair points, I pushed the changes as requested :)

dagre commented 7 years ago

Will do, thanks!