search

bastislack / highline-freestyle

Webapp for Highline Freestyle
GNU General Public License v3.0
10 stars 9 forks source link

Editing tricks does not store the changes (properly) #240

Closed JulianDietzel closed 1 year ago

JulianDietzel commented 1 year ago

When a predefined trick is edited and then saved, it does not get stored (properly). No error is raised but when clicking on the trick again, the changes do not show up. (Very very occasionally I can manage for the changes to show up, I don't have a clue as to how though)

This is probably a result of the saveTrick function being used to update the (predefined) trick, whilst actually being designed to store user tricks (at least according to the comment above the function). So the update actually does get stored, but in the userTricks table. (Therefore I assume that the issue only occurs for predefined tricks, I could not test this though due to issue #234).

I am not sure if this is done intentionally so as to keep the predefined tricks untouched and store the changes in the userTricks table or if this is an oversight.

Also, searching for the error, I noticed that Dexies put() function is used in a lot of places where update() would be more appropriate (this is probably the reason why tricks get "unboosted" / when the stickFrequency is changed). put() overwrites the entire entry instead of just updating the provided fields. Maybe this is related to the issue.

weberax commented 1 year ago

I could not reproduce this. @JulianDietzel is this still a bug?

weberax commented 1 year ago

I had a deeper look on this and changed some stuff (acfc28fa, 6bc5de8a). Also with either the rewrite coming up, I would close this issue for now