search

bastislack / highline-freestyle

Webapp for Highline Freestyle
GNU General Public License v3.0
10 stars 9 forks source link

Make trick and combo list button fonts consistent #255

Closed DavidKaep closed 1 year ago

DavidKaep commented 1 year ago

This fixes #254 by removing btn-outline-success from the class-name and making the combo-preview consistent with the trick-preview in the index.css file.

Heres the result on the combo page:

Screenshot

On the trick page (nothing changed here):

Screenshot

Before:

image

JulianDietzel commented 1 year ago

Good change, looks much better to my eyes, too. While at it we could even take this a small step further:

I'd suggest merging the combo-preview and trick-preview classes into one preview-item class and reference this class from both the ComboList and the TrickList. This way the index.css gets shorter, there is less duplicate code and the chance that the two designs will get out of sync again is lowered greatly.

Another change in the vein of "while we are at it" would be to get rid of the .combo-preview h3 and trick-preview h3 sections in the index.css. The .trick-preview h3 section is already not in use and after your changes .combo-preview h3 becomes unused as well.

bastislack commented 1 year ago

@DavidKaep Nice, I had this on my mind already since a while! @JulianDietzel's suggestions would be a nice upgrade as well, if you're motivated to implement that (otherwise we can just make a new issue for that) :)

DavidKaep commented 1 year ago

I made the changes recommended by @JulianDietzel now the h3 headers are gone from the index.css and the previews are merged into a singe preview-item