JulianDietzel commented 9 months ago

I created a responsive navbar with the following five routes:

Tricks: /tricks
Combos: /combos
Glossary: /glossary
Generator (Combo Generator): /generator
More (This is where I'd put the few settings we have, the imprint and a short About section): /more

The navbar comes in only a light theme for now as I think that this is what we should design for first and has language support for English, Spanish and German. It is responsive, switching from a bottom navigation to a side bar at the lg-breakpoint of Tailwind. I'm going back and forth whether the xl-breakpoint should be used. I think the way I did it is the way though let me know if you know any good reasons for using one or the other.

Mobile	Desktop

I also added one npm script which serves the website in a manner so that other devices of the network can access the page. It can be run with npm run host.

@bastislack @Dosbodoke Le me know if you have any feedback on the design. @WaldemarLehner Can you take a look and make sure I didn't mess up anything with Vue / TailwindCSS.

JulianDietzel commented 9 months ago

After talking to @hell3nacht about it, we slightly changed the highlighting of the router items. I also changed the background to white in order to actually see the navbar with the correct matching background color:

Mobile	Desktop

WaldemarLehner commented 9 months ago

I havent looked at the code yet... Yet I would still do one Suggestion in regardsvto path naming.

We should stick to a REST-like naming scheme as much as possible.

This would mean getting all combos at /combos, getting a specific combo at /combos/$id and so on.

I think that /generate breaks that convention. I would suggest /combos/new or /combos/create or /combos/new/generate if generation should be wildly different from 'manual' creation .

I would also rename /more to /about, as it gives a clearer description of what this page does.

JulianDietzel commented 9 months ago

Currently blocked by unresolved issue #305 (missing component library)

JulianDietzel commented 8 months ago

305 has been resolved by PR #311 . Now further work is blocked by the unmerged PR #316. The change is needed in order to be able to use the primary color with different brightness levels. Once that is merged there should be no further issues and I can finish the navbar.

JulianDietzel commented 8 months ago

Replaced by PR #318.

bastislack / highline-freestyle

Rewrite responsive navbar #303

305 has been resolved by PR #311 . Now further work is blocked by the unmerged PR #316. The change is needed in order to be able to use the primary color with different brightness levels. Once that is merged there should be no further issues and I can finish the navbar.