bastislack / highline-freestyle

Webapp for Highline Freestyle
GNU General Public License v3.0
10 stars 9 forks source link

Add Shadcn #311

Closed Dosbodoke closed 8 months ago

Dosbodoke commented 9 months ago

What is the purpose of this PR?

Add shadcn as the project component library.

What was done to achieve it?

Followed the documentation of installing shadcn in a Vue + Vite application

We will need to use the CLI in order to use this library, this was a thing that I have pointed as as benefic to the Shadcn approach, the ability to just copy and paste the components, but now I found that the vue library only allow to install via CLI

VUE Shadcn React Shadcn
VUE Shadcn React Shadcn

As you can see, the React library has a guide to install the components manually, and in most cases is the same steps

I don't see this as a problem, but we will need to have a new components.json file at the root of the project that is needed to use the CLI.

About theming, there has a documentation to do it, we can iterate more on this.

How to test if it works?

This change can impact another functionality?

It can change the current style, but I think this is not a concern at the moment.

WaldemarLehner commented 9 months ago

Please merge rewrite into this branch to fix the Pipeline.

JulianDietzel commented 8 months ago

Apart from the question why the "xs" breakpoint was removed, this looks good to me :+1:

We should then address adjusting the theming according to #309 in a follow up PR.