search

bastislack / highline-freestyle

Webapp for Highline Freestyle
GNU General Public License v3.0
10 stars 9 forks source link

feat(ui): Add proper navbar #318

Closed JulianDietzel closed 8 months ago

JulianDietzel commented 8 months ago

Adds a proper responsive navbar for both desktop (side) and mobile (bottom). Replaces PR #303.

The navbar routes to

The navbar has a language selector to select between English, Spanish and French.

Here is how the navbar looks. Dropdown in the mobile view can be opened with the three dots on the right and is not always visible: Desktop Mobile
Bildschirmfoto am 2023-12-06 um 20 37 26 Bildschirmfoto am 2023-12-06 um 20 36 56

I had to install lucide-vue-next despite us already having a library for icons. This is due to an issue with shadcn's dropdowns. If the library is not installed and a dropdown is used, a runtime error occurs, pointing to to the missing package.

JulianDietzel commented 8 months ago

Found a bug: When the dropdown is open in the mobile navbar and the screen gets resized so that the side navbar becomes active, the dropdown stays open and visible instead of disappearing with the bottom navbar. Hence the change to a draft. I'll fix this first, then convert it back to a proper PR.

WaldemarLehner commented 8 months ago

I don't see this as an issue tbh.

It's an edge case that happens on a resize that has no negative side effect.

If the drop down stays open, even after clicking somewhere else in the app, then yeah. That has to be resolved.

But if its just open in this very niche edge case? I'd classify that as a won't fix

On Thu, 7 Dec 2023, 13:25 Julian Dietzel, @.***> wrote:

Found a bug: When the dropdown is open in the mobile navbar and the screen gets resized so that the side navbar becomes active, the dropdown stays open and visible instead of disappearing with the bottom navbar. Hence the change to a draft. I'll fix this first, then convert it back to a proper PR.

— Reply to this email directly, view it on GitHub https://github.com/bastislack/highline-freestyle/pull/318#issuecomment-1845253559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGTHPAIEAABTHOIBTO43WPLYIGYUVAVCNFSM6AAAAABAJ7AHEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGI2TGNJVHE . You are receiving this because your review was requested.Message ID: @.***>

JulianDietzel commented 8 months ago

Agreed, won't fix for now