search

bastislack / highline-freestyle

Webapp for Highline Freestyle
GNU General Public License v3.0
10 stars 9 forks source link

feat: add adaptive favicon #333

Closed JulianDietzel closed 7 months ago

JulianDietzel commented 7 months ago

Modified the favicon so that it is a) properly displayed and b) adapts to the theme of the browser (the icon is dark when the theme is light and vice versa). This should warp up issue #161 and is the second attempt at this, with #331 being the first but rejected one.

The more elegant method used to make the favicon adapt to the browser theme in this PR was recommended by @WaldemarLehner in #331 . It relies on styling in the svg-file itself.

WaldemarLehner commented 7 months ago

From purely looking at the changes this looks good

Cannot test locally as my root partition just s.... the bed :(

JulianDietzel commented 7 months ago

Sweet. It runs on both my Ubuntu Laptop (Firefox) and my Android Phone (also Firefox) so I thinks this should be super good enough