Closed StephenTerry closed 6 years ago
Another option was to just modify your pull request 😄
Wasn't sure how to do that :)
I think you just add another commit and it will show up here as part of the PR.
Usually when I do this for other projects, on my own fork, I make a specific branch just for the feature / PR. Then I just keep committing to that branch.
Ah ok. I thought it would be cleaner to only have one commit rather than two.
Yes, I would agree. However, when the owner/maintainer merges the pull request, there is an option to squash commits. So that isn't really a worry anymore. They typically give an example where there a bunch of testing/typo commits, but you don't want them cluttering master's commit history.
When the CalculateVolume function in dvhdata.py was called, there was a call to the itervalues() method, which is not used in Python 3. This was changed to use the itervalues method in the six library. Additionally, the dictionary for each contour slice now has the key 'data' instead of the previous 'contourData' key.