Open c-amow opened 5 years ago
Thank you for reporting this. I will try to see if I can reproduce this issue in a linux VM.
I wonder if the issue is with the values sent to the progress bar or with wxPython/wxWidgets itself for GTK3.
The files you sent do work on the Mac version.
I cloned the repo on Arch, install dependencies and can reproduce this issue. The prebuilt Windows binary (0.4.2) is okay.
I added this print(num, length, percentDone, message)
in guiutil.py::OnUpdateProgress()
right after percentDone
is computed.
Here is the log:
...
131 135 97 Processing DICOM data...
132 135 97 Processing DICOM data...
133 135 98 Processing DICOM data...
134 135 99 Processing DICOM data...
134 4 3350 Done
gaugeProgress.SetValue(percentDone)
with 3350
is what causes the error.
We should move the code for handling "Done" case prior to setting progress in guiutil.py::OnUpdateProgress()
.
I don't know why this works in the first place. There's no change in caller (treeview.py::RecurseTreeThread()
).
I now fix with this (rather then moving the code block):
if not length:
percentDone = 0
else:
# Fix #115, clip value
percentDone = max(0, min(int(100 * (num) / length), 100))
Install of the various pieces seemed to all eventually go through without any errors.
Using the two files at https://medistim.com/dicom/ On linux (based on ubuntu 18.04) I can only get bmode.dcm to "Open quickly" and then when I select Ultrasound Multi-frame Image, the Loading DICOM data progress bar comes up and gets to 98% before emitting (and then hanging indefinitely):
The windows version fills in the DICOM tree.
Not sure how best to diagnose this, some additional info: import wx wx.version() 4.0.3 gtk3 (phoenix) wxWidgets 3.0.5
dpkg -s libgtk-3-0|grep '^Version' Version: 3.22.30-1ubuntu1
I did have to do two extra things to get it to run on linux:
this was after:
Thanks for any insight you can offer and the awesome project in general - it will be nice to have consistent viewing with team mates on the Mac and Windows!