search

basvandijk / scientific

Arbitrary-precision floating-point numbers represented using scientific notation
BSD 3-Clause "New" or "Revised" License
73 stars 40 forks source link

Make bytestring-builder's installation conditional based on a Cabal flag #42

Closed RyanGlScott closed 8 years ago

RyanGlScott commented 8 years ago

I goofed a bit when creating #41. I intended to solve the problem of making Data.ByteString.Builder.Scientific always available regardless of GHC version, but I did so in a rather unhygienic way. I made scientific depend on bytestring-builder conditionally if an older GHC version was used, but as @phadej shows, it's quite easy to construct a build plan in which a recent GHC version installs an old bytestring version.

What I should have done originally (and what this PR accomplishes) is make bytestring-builder conditionally installed depending on a Cabal flag. In fact, this was what was done earlier, except that manual was set to True, so cabal-install couldn't switch off the bytestring-builder flag if the solver deemed it unneeded.

Note that this PR bumps the minimum version of cabal-install required by the Travis script to 1.18, since there have been bugs observed with older versions of the cabal-install dependency solver.

basvandijk commented 8 years ago

Thanks! Released as 0.3.4.8.