search

basvandijk / scientific

Arbitrary-precision floating-point numbers represented using scientific notation
BSD 3-Clause "New" or "Revised" License
73 stars 40 forks source link

0.3.6.0 does not build with base< 4.8 #65

Closed ivan-m closed 6 years ago

ivan-m commented 6 years ago

From my build log (with both GHC 7.6 and 7.8):

Downloading scientific-0.3.6.0...
Configuring scientific-0.3.6.0...
Building scientific-0.3.6.0...
Preprocessing library scientific-0.3.6.0...
[1 of 5] Compiling GHC.Integer.Compat ( src/GHC/Integer/Compat.hs, dist/build/GHC/Integer/Compat.o )
[2 of 5] Compiling Utils            ( src/Utils.hs, dist/build/Utils.o )
[3 of 5] Compiling Data.Scientific  ( src/Data/Scientific.hs, dist/build/Data/Scientific.o )
src/Data/Scientific.hs:192:34:
    Not in scope: `*>'
    Perhaps you meant one of these:
      `*' (imported from Prelude),
      `<*>' (imported from Control.Applicative),
      `>>' (imported from Prelude)
Failed to install scientific-0.3.6.0

I suspect that line 125 needs to include (*>) as well.

basvandijk commented 6 years ago

Whoops, I wasn't paying attention to the travis builds of GHC < 8 because they were failing for a while due to a failing test dependency. scientific-0.3.6.1 will now build on GHC < 8 and I disabled the test-suite in travis for the GHC < 8 builds so all jobs are green now.

ivan-m commented 6 years ago

Ta!

gwils commented 6 years ago

As a hackage trustee I've made a hackage metadata revision on scientific-0.3.6.0 to tighten its base lower bound to >=4.8